Description

Sometimes, NpmTasks are failing with being unable to find files/commands under npmProjectDir. Here's an example of such a failure. The failing tasks always execute after the nodeSetup task for that project, so in theory, everything should be in place.

However, in this case, multiple subprojects share the same npmProjectDir. The way the gradle-node-plugin works, having multiple projects use the same npmProjectDir doesn't save work, and can actually cause timing issues like the failures we are seeing. This is because each nodeSetup task clears out the old directory before it unpacks it again. In the Timeline view of the same Build Scan linked above, we can see that the :solr:solr-ref-guide:downloadAntoraCli task (an NpmTask), is executing at the same time as :solr:packaging:nodeSetup, and downloadAntoraCli can't find node because it's been cleared out by another suproject's nodeSetup task.

Solution

This PR updates each subproject to use its own individual nodeProjectDir to avoid these timing issues. Separating these out doesn't result in node being downladed twice - despite unpacking the same version multiple times, it's only ever downloaded once. So no extra work is being done, since sharing the same nodeProjectDir doesn't save work in the first place, as explained above.

Tests

No new tests were added, and no existing tests were modified, but the check and integrationTests tasks consistently pass when run locally with these changes.

Checklist

Please review the following and check all that apply:

• I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• I have created a Jira issue and added the issue ID to my pull request title.
• I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
• I have developed this patch against the main branch.
• I have run ./gradlew check.
• I have added tests for my changes.
• I have added documentation for the Reference Guide